Inherit env vars in sudo uses.

GoogleCloudPlatform / runtimes-common

Common tools used by the GCP runtimes.

Apache License 2.0

94 stars 53 forks source link

Inherit env vars in sudo uses. #807

Open msuozzo opened 2 years ago

jinglundong commented 2 years ago

Hi @msuozzo, thanks for proposing this change. I need a bit time and research to understand the impact of this change. If you could help me understand the following questions, I would be able to approve it much faster:

Why do we need to make this change? Is the previous version (w/o -E) causing any issues?
Why is it safe to do so? I'm asking because this is a flag to sudo.

jinglundong commented 2 years ago

Discussed internally. This looks good to me.

msuozzo commented 2 years ago

do you know what the CI issue could be here? doesn't seem to be resolving

jinglundong commented 2 years ago

Seems like there's no links to check the kokoro status. I'm also seeing that kokoro Expected — Waiting for status to be reported message for over 12 hours.

jinglundong commented 2 years ago

To move forward, you may look for the corresponding kokoro workflow to this repo. (I'm working on a high priority bug, so couldn't dive too deep into this today. )