search

GoogleCloudPlatform / samples-style-guide

Guidelines on writing effective Google Cloud samples.
https://googlecloudplatform.github.io/samples-style-guide/
Apache License 2.0
11 stars 19 forks source link

Added Terraform to existing style guide #101

Closed betsy-lichtenberg closed 1 year ago

betsy-lichtenberg commented 1 year ago

Proposing Terraform for inclusion in https://googlecloudplatform.github.io/samples-style-guide/.

See:

averikitsch commented 1 year ago

Hi @betsy-lichtenberg , is it possible for you to recreate this PR by pushing directly to this repo rather than your fork? This will allow for a preview of the site to be generated.

grayside commented 1 year ago

I've started a review, and once underway identified I'm reviewing on two many "roles" at once.

  1. We need a review for Terraform samples practices by an SME looking for completeness & correctness of the guidelines
  2. We need a review for style guide "style", alignment to existing guidelines, and actionability. That's my primary role as a reviewer.
  3. We need an impact review that confirms the work implied in the style guide is something manageable for contributors & reviewers. That's a review by myself and @iennae

I would like someone to provide a Terraform Samples expert review before I resume my review which will focus on (2) and (3), but may contain elements of (1) if there's still feedback needed there.