GoogleCloudPlatform / samples-style-guide

Guidelines on writing effective Google Cloud samples.
https://googlecloudplatform.github.io/samples-style-guide/
Apache License 2.0
11 stars 19 forks source link

feat: Site Previews for PR Reviews #46

Closed grayside closed 2 years ago

grayside commented 2 years ago

This change introduces PR Previews based on research done in https://github.com/grayside/gh-page-previews.

Key changes to the github_pages workflow:

Preview resources are entirely cleaned up when the PR is closed.

github-actions[bot] commented 2 years ago

๐Ÿš€ Preview at https://GoogleCloudPlatform.github.io/samples-style-guide/previews/PR-46/

grayside commented 2 years ago

I did some additional digging. When docsy has changes to the underlying JS or SCSS, we will have additional files for minification. They are kept side by side to ease transition where HTML was cached but not the other static assets.

Since this doesn't change with content, I think it's reasonable to have periodic manual cleanup.

github-actions[bot] commented 2 years ago

๐Ÿ”Ž Preview at https://GoogleCloudPlatform.github.io/samples-style-guide/previews/PR-46/

github-actions[bot] commented 2 years ago

๐Ÿ”Ž Preview at https://GoogleCloudPlatform.github.io/samples-style-guide/previews/PR-46/

github-actions[bot] commented 2 years ago

๐Ÿ”Ž Preview at https://GoogleCloudPlatform.github.io/samples-style-guide/previews/PR-46/

github-actions[bot] commented 2 years ago

๐Ÿ”Ž Preview at https://GoogleCloudPlatform.github.io/samples-style-guide/previews/PR-46/

github-actions[bot] commented 2 years ago

๐Ÿ”Ž Preview at https://GoogleCloudPlatform.github.io/samples-style-guide/previews/PR-46/

github-actions[bot] commented 2 years ago

๐Ÿ”Ž Preview at https://GoogleCloudPlatform.github.io/samples-style-guide/previews/PR-46/

github-actions[bot] commented 2 years ago

๐Ÿงจ Preview deployments removed.