search

GoogleCloudPlatform / scientific-computing-examples

Open Source examples using Google Cloud to solve various Scientific and Technical Computing problems.
Apache License 2.0
17 stars 11 forks source link

[flux] Suggestion: don't require cloud build #59

Open vsoch opened 1 year ago

vsoch commented 1 year ago

I tried cloud build again today (I'm working on a PR that will allow a custom broker config, likely will put in soon!) and I ran into the same mysterious error as before. If this extra dependency is going to be something that regularly breaks, I want to suggest having an approach that uses packer without needing cloud build. The recipes I'm currently using are here:

https://github.com/converged-computing/flux-terraform-gcp/tree/main/build-images

I can use those for now, but would be nice to use a single source of truth (from the repository here) for the future!

vsoch commented 1 year ago

Another suggestion - for the set of images that I'm able to build (using just packer and terraform, my setup, because I can't use Google Build any longer) I removed arm images, because we don't need them now (and it doesn't make sense to pay for the build and storage in that case!) But then when I use the recipes here with my image builds, even when I'm not needing arm, it totally fails looking for the family. Since I don't have that family what I'm doing now is faking a build (renaming an x86 to be arm) just to (hopefully) get it to work - I did try adding back arm but got an SSH timeout (likely meaning the instance isn't starting) and it's beyond what I want to debug tonight. So the suggestion is to make the arm image setup optional, because it doesn't make sense to spend the time / make people pay for them (and then get a bug!) if they don't need them. What do you think?

vsoch commented 1 year ago

Another thing I could do is duplicate a lot of the logic here and maintain it alongside the variant I'm working on. It's not ideal, but if the two designs are going to converge too much (e.g., I can't use my images with the recipes here) it might be a reasonable thing to do.

Sorry for all the pings - I know tomorrow / Tuesday are holidays! I know you get it off at Google but we do not :sob:

This is me: https://www.instagram.com/reel/CuCiazduo3J/?igshid=M2MyMzgzODVlNw==