GoogleCloudPlatform / security-response-automation

Take automated actions against threats and vulnerabilities.
Apache License 2.0
208 stars 52 forks source link

Add scc etd iam anomalous iam grant support #127

Closed walves-cit closed 4 years ago

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

walves-cit commented 4 years ago

@googlebot I signed it!

[]'s Weslley Alves Assumpção • Senior Software Engineer CI&T • Collaborate. Innovate. Transform. walves@ciandt.com • ciandt.com

On Tue, Nov 26, 2019 at 12:04 PM googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA Individual signers

Corporate signers

ℹ️ Googlers: Go here https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2FGoogleCloudPlatform%2Fsecurity-response-automation%2Fpull%2F127 for more info.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/security-response-automation/pull/127?email_source=notifications&email_token=ANJNQ3I7EH24BW2MRBUL2LTQVU3JVA5CNFSM4JRZMEBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFGKIRA#issuecomment-558670916, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANJNQ3JIS2T2KUGZLCL4IHDQVU3JVANCNFSM4JRZMEBA .

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

walves-cit commented 4 years ago

looks good, just a few things, i didn't get a chance to look too indepth:

  • i see you renamed the directory of protos from sha to scc. we should probably keep the protos separate per provider. this matches the directory structure providers/etd, etc. i get where you were going with this, you need different protos per source but they can be in the same file as the provider.
  • in the future its good to minimize the size and depth of this PRs. meaning even if we did want to rename the dir lets do it in a separate PR. its just easier for review etc

Make sense... I'll revert this renaming and add the new ETD message from SCC source following this mindset.