search

GoogleCloudPlatform / security-response-automation

Take automated actions against threats and vulnerabilities.
Apache License 2.0
208 stars 52 forks source link

Use official documentation steps to create SCC Notifications in README. #177

Closed atos-cit closed 4 years ago

atos-cit commented 4 years ago
atos-cit commented 4 years ago

can we maybe put in the commands needed into our documentation? i'd be worried with sending folks to another page without the guidance. maybe we can just put the commands here so they can just paste in a few gcloud commands.

we should also remove the ./local/cli/main.go binary too

We can include the commands in README, because it is basically a gcloud command to create the notifications and the PR #166 already enables the security center api. We could just move this section after the installation of the automations to things work correctly, since the api will be enabled (after the merge of the #166) and the topic created.

tomscript commented 4 years ago

ya lets do that. lets remove the go binary and place in the gcloud commands in the README as per the official documentation for cscc notifications.