GoogleCloudPlatform / security-response-automation

Take automated actions against threats and vulnerabilities.
Apache License 2.0
208 stars 52 forks source link

Fix Event Threat Detection findings ingestion #190

Closed daniel-cit closed 4 years ago

daniel-cit commented 4 years ago

What is in this PR:

Observations:

daniel-cit commented 4 years ago

meta comment - lets really aim for small PRs. so if you have to list 5 or so bullets, probably each bullet should be its own PR. this keeps reviews simple and quick

Hi Tom, good to see you again.

The last two bullets:

Are easy to move to two different pull requests, but I don't know which is the best strategy to slice the changes in the parsing of the ETD findings.

We have three findings:

and two formats:

and their parsing depends on code generated by the protobuf compiler reading from a single file providers/etd/protos/etd.proto which will be a cause of conflict in every PR.

Which would be better in this case?

@tomscript any advice on this ?