GoogleCloudPlatform / security-response-automation

Take automated actions against threats and vulnerabilities.
Apache License 2.0
208 stars 52 forks source link

Added Rego-based Filter Cloud Function for false positives #198

Closed onetwopunch closed 3 years ago

onetwopunch commented 3 years ago
tomscript commented 3 years ago

this is really fantastic thanks again Ryan!

tomscript commented 3 years ago

Ryan did you see the build failed? i wonder if it uses the old ver of golang?

https://github.com/GoogleCloudPlatform/security-response-automation/actions/runs/368990058

onetwopunch commented 3 years ago

Ah yes it looks like the Github action is using Go 1.11. I didn't even realize that was checked since it wasn't set up to block a merge. Lemme make a separate PR for this

onetwopunch commented 3 years ago

For future readers, the issue Tom pointed out about tests failing has been fixed in #200 and was due to Go version and plugin version being out of date in the github workflow.