Add the manifests validation and preparation to the CICD pipeline

GoogleCloudPlatform / solutions-modern-cicd-anthos

An end-to-end operating model for onboarding and continually deploying services with Anthos.

Apache License 2.0

86 stars 60 forks source link

Add the manifests validation and preparation to the CICD pipeline #101

Closed nan-yu closed 4 years ago

nan-yu commented 4 years ago

Two new stages are added to the CICD pipeline for the app-template:

validate-manifests: validate the hydrated manifests using appctl
prepare-manifests: hydrate, validate and push the manifests to the deployment repo

The validate-manifests stage will run for each commit, the prepare-manifests stage will only run for commits in the master branch.

nan-yu commented 4 years ago

cc @janetkuo @yuwenma @Liujingfang1 @haiyanmeng

yuwenma commented 4 years ago

overall LGTM. one question regarding the ssh key. Shall we also call appctl validate for prod?

yuwenma commented 4 years ago

/lgtm

nan-yu commented 4 years ago

Added one more commit to this PR to support docker-in-docker as appctl uses kpt to run validation, which requires a docker deamon inside the appctl docker container.

nan-yu commented 4 years ago

Added a new commit to configure validate-manifests and prepare-manifests stage to run only when changes in the following files:

config/*/
delivery/*/
validation/*/

FYI: @Liujingfang1 @janetkuo @haiyanmeng @yuwenma ^^

nan-yu commented 4 years ago

@yuwenma This is how we configure the gitlab-runner to always pull the latest image: https://github.com/GoogleCloudPlatform/solutions-modern-cicd-anthos/pull/101/commits/0b72ff7832f723c0b536bba50452eb544a94fe1b.

nan-yu commented 4 years ago

The two stages were verified to be working with the appctl image. This PR is ready to be re-reviewed and merged.