search

GoogleCloudPlatform / solutions-serverless-web-monitoring

Apache License 2.0
22 stars 12 forks source link

Terraform destroy never runs if e2e test fails #1

Open jaketf opened 3 years ago

jaketf commented 3 years ago

GCB doesn't allow running steps if prior steps failed which means the e2e will leak resources if it does not pass. Would it be a better example to create a pytest fixture to run / teardown terraform (example)?

https://github.com/GoogleCloudPlatform/solutions-serverless-web-monitoring/blob/e40a183ad1f435995a50f939567f852659b8e439/cloudbuild.yaml#L68

jaketf commented 3 years ago

BTW this example was super useful to me :)