GoogleCloudPlatform / spanner-migration-tool

Spanner migration tool helps you migrate from your existing database/dump files to Spanner
https://googlecloudplatform.github.io/spanner-migration-tool/
Apache License 2.0
115 stars 60 forks source link

Web UI fails to parse password with equals symbol on Migrate #643

Open joshbautista opened 1 year ago

joshbautista commented 1 year ago

Expected Behavior

When clicking Migrate on the final page, SMT should start the migration.

Actual Behavior

When clicking Migrate on the final page, SMT throws an error, displaying sensitive info in plaintext:

Can't get source and target profiles: error while preparing prerequisites for migration: could not parse source-profile, error =
invalid key=value pair (expected format: key1 =value1):
password=this=isvalid
smt-web-pw-parse-error

Steps to Reproduce the Problem

  1. Create a PostgreSQL user with appropriate SMT permissions that has an equals = symbol in its password (e.g. this=isvalid)
  2. Use that user during the initial Connect to Database screen
  3. Go through the migration steps to the last page (doesn't matter if it's a POC or Low Downtime Migration)
  4. Click Migrate

Specifications

go version go version go1.21.0 linux/amd64

Browser

Chrome Version 117.0.5938.92 (Official Build) (x86_64) on MacOS 13.5.2

bharadwaj-aditya commented 1 year ago

We'll look into this and get back.