search

GoogleCloudPlatform / spinnaker-for-gcp

Production-ready Spinnaker on GKE
175 stars 131 forks source link

fix: setup scripts fail to create cluster v1.18.16 #230

Closed jimangel closed 3 years ago

jimangel commented 3 years ago

Following the marketplace tutorial, the current GKE version 1.18.16 in setup_properties.sh fails with errors around the inability to enable basic auth.

Basic auth removal

This PR removes --username "admin" (basic auth).

Q: Does disabling basic auth impact any extended operations beyond setup?

I skimmed the docs and didn't see basic auth references and gcloud captures GKE credentials.

Version tweaks

Looking at the history of setup.sh, most of the commits are GKE_VERSION house keeping.

image

The PR also swaps out a specific cluster version with a release channel variable GKE_RELEASE_CHANNEL. Also, GKE_CLUSTER_VERSION is no longer necessary.

image

I understand there's value to pinning a specific version in production clusters. However, it's safe to assume the setup script will only run the first time. As folks adopt "day-2" operations, an upgrade plan will follow.

jimangel commented 3 years ago

It looks like this was also addressed in https://github.com/GoogleCloudPlatform/spinnaker-for-gcp/pull/229 but I think removing the version pin is a better long term solution. Open to feedback!

/cc @plumpy