search

GoogleCloudPlatform / spring-cloud-gcp

New home for Spring Cloud GCP development starting with version 2.0.
Apache License 2.0
423 stars 315 forks source link

Remove commons-logging from classpath #2000

Closed burkedavison closed 11 months ago

burkedavison commented 1 year ago

Pubsub-stream-binder and logging integration tests produce this message:

Standard Commons Logging discovery in action with spring-jcl: please remove commons-logging.jar from classpath in order to avoid potential conflicts

(Example log)

This dependency is brought in via spring-cloud-gcp-logging's com.google.cloud:google-cloud-logging-logback dependency, and spring-cloud-gcp-pubsub's com.google.cloud:google-cloud-pubsub dependency.

zhumin8 commented 11 months ago

Adding a note: we should remove commons-logging from classpath for all artifacts published via SCGCP

zhumin8 commented 11 months ago

fixed by #2407, and remaining cleanup after https://github.com/googleapis/google-http-java-client/pull/1905 has been released captured in #2415. Thus closing this one.