GoogleCloudPlatform / spring-cloud-gcp

New home for Spring Cloud GCP development starting with version 2.0.
Apache License 2.0
414 stars 308 forks source link

feat: spring boot 3.3.1 #2990

Closed burkedavison closed 3 months ago

burkedavison commented 3 months ago

Spring Boot 3.3.x upgraded Brave and Zipkin dependencies by a major version with significant backward incompatibilities. For this reason, the trace module which uses them is unable to be maintained with support for Spring Boot 3.2.x.

Testing has been added to ensure Spring Boot 3.2.x support is maintained for all modules except Trace.

breun commented 3 months ago

If Spring Cloud GCP 5.x aims to maintain compatibility with Spring Boot 3.2.x and 3.3.x, it could be dangerous to upgrade to Spring Boot 3.3.x. Sticking with 3.2.x would avoid accidentally using API which is not available in Spring Boot 3.2.x.

Or will compatibility with Spring Boot 3.2.x be guaranteed in some other way?

burkedavison commented 3 months ago

@breun : Agreed with your concern. We'll have an answer before merging.

burkedavison commented 3 months ago

image

Compatibility table updates from https://github.com/GoogleCloudPlatform/spring-cloud-gcp/pull/3000 merged here + added an exception for trace module compatibility. Main branch testing now include Spring Boot 3.2 sample tests.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

burkedavison commented 2 months ago

Fixes #2917