GoogleCloudPlatform / spring-cloud-gcp

New home for Spring Cloud GCP development starting with version 2.0.
Apache License 2.0
397 stars 294 forks source link

Generator StackOverflow on mvn install #3005

Open burkedavison opened 1 week ago

burkedavison commented 1 week ago

Steps to replicate:

blakeli0 commented 6 days ago

Bump to P1 as it is blocking the release now.

diegomarquezp commented 6 days ago

Confirmed it occurs with maven 3.8.6 If I sdk use maven 3.9.6 there is no StackOverflowError

edit: Now I see the repo has a .mvn folder configured with 3.9.x. I'm not sure how this config file affects which version is used in the CI

diegomarquezp commented 6 days ago

The fix is to use ./mvnw since it's configured with 3.9.x. We recently fixed the release scripts by doing this in https://github.com/GoogleCloudPlatform/spring-cloud-gcp/pull/3015 and confirmed that stage.sh was successful. Pending: investigate release notes of Maven and Maven Assembly Plugin to see why Maven 3.9 doesn't produce this error.