search

GoogleCloudPlatform / stackdriver-errors-js

Client-side JavaScript exception reporting library for Cloud Error Reporting
https://cloud.google.com/error-reporting/
Apache License 2.0
362 stars 54 forks source link

Send the original event to old onunhandledrejection call #119

Closed DavidEspinola closed 2 years ago

DavidEspinola commented 2 years ago

Hi! Just a quick proposal: I was checking your code and I think if we pass only the reason here, we can break the original handler as it would stop receiving the full event. What do you think?

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

steren commented 2 years ago

Thanks, I believe you are correct.