search

GoogleCloudPlatform / stackdriver-errors-js

Client-side JavaScript exception reporting library for Cloud Error Reporting
https://cloud.google.com/error-reporting/
Apache License 2.0
362 stars 54 forks source link

Unversion dist folder and generate in prepare #48

Closed bz2 closed 6 years ago

bz2 commented 6 years ago

Rather than including build time generated source files in the repository, use the npm prepare step to create the dist folder contents after local install and before publishing.

steren commented 6 years ago

I was versioning the dist directory in order to be able to deliver the script like this:

<script defer src="https://cdn.jsdelivr.net/gh/GoogleCloudPlatform/stackdriver-errors-js@v0.4.0/dist/stackdriver-errors-concat.min.js"></script>

If you remove it from the repo, please also update the README instructions. I guess there is a way to point to what is in npm?

bz2 commented 6 years ago

Looks like we can indeed serve it out of npm instead:

https://cdn.jsdelivr.net/npm/stackdriver-errors-js@0.5.0/dist/stackdriver-errors-concat.min.js

I'll update the README with that suggestion (will need to remember to bump the @version each time too).