search

GoogleCloudPlatform / stackdriver-errors-js

Client-side JavaScript exception reporting library for Cloud Error Reporting
https://cloud.google.com/error-reporting/
Apache License 2.0
362 stars 54 forks source link

package installed via npm doesnt have type definition #97

Closed mohamedfasil closed 3 years ago

mohamedfasil commented 3 years ago

Hi typings is missing when we install via npm 

npm install stackdriver-errors-js

Screenshot 2021-08-24 at 5 59 41 PM

k0walik commented 3 years ago

I think there is a mismatch between script entry point and types file definition. If we rename the definition file to stackdriver-errors.d.ts (and make corresponding update in package.json) it works as expected.

I created PR for that: https://github.com/GoogleCloudPlatform/stackdriver-errors-js/pull/98

casparolesen commented 3 years ago

@steren Any chance we can get a new release with the renamed definition file? 😄

steren commented 3 years ago

I'm pushing to npm now

casparolesen commented 3 years ago

I'm pushing to npm now

It seems that the definition file isn't included in the npm package? This is the contents of the folder on 0.11.0:

image

steren commented 3 years ago

Ah, I guess the script that generates the release is not capturing the .d.ts file.

If you can send a PR to fix that, that'll be helpful

steren commented 3 years ago

Tracked at https://github.com/GoogleCloudPlatform/stackdriver-errors-js/issues/100