search

GoogleCloudPlatform / terraform-dynamic-python-webapp

Deploy a dynamic python webapp
avocano.dev
Apache License 2.0
75 stars 43 forks source link

fix(issue-143): resolve periodic assertion failures #144

Closed pattishin closed 1 year ago

pattishin commented 1 year ago

Issue: #143

Removing assertion line since we are already checking in a latter step.

pattishin commented 1 year ago

I would suggest to make a separate condition method for "oneOf" instead of using argument that a code reader has to track to the function's implementation.

That makes sense to have a cleaner implementation. This is meant to be a minimal change/ patch for the moment to unblock, but comments have been added to revisit.

donmccasland commented 1 year ago

We are in a code freeze for solutions' deployment code, but since this change only impacts the testing code, we are good to go forward on this.

pattishin commented 1 year ago

Appreciate it Don & Marc! ty!