Closed chris-ingrisani closed 3 years ago
@bharathkkb I updated the code to remove the complete fork - let me know if this is sufficient. Will add readme by end of day.
Thanks @chris-ingrisani, lets also make sure lint tests are passing and we switch temporary FW rules needed to gcloud commands in the readme.
Thanks @chris-ingrisani, lets also make sure lint tests are passing and we switch temporary FW rules needed to gcloud commands in the readme.
@bharathkkb No problem! It looked like the lint tests were failing since the module isn't yet defined - even with source = "../../modules/base_shared_vpc"
the lint tests weren't working. Should I be using the networking module instead? Undeclared input variables was the other issue and those were left out since they are included in the main base_shared_vpc module, but I can add them in to ensure the tests pass.
@chris-ingrisani there is no modules folder in your commit, instead as we are not going to fork the CFT 3-networks you can use
source = "github.com/terraform-google-modules/terraform-example-foundation/3-networks/modules/base_shared_vpc"
@bharathkkb Please review latest commit and let me know if any additional changes are required.
This PR adds the network layer to the example app foundation.