search

GoogleCloudPlatform / terraform-example-foundation-app

https://registry.terraform.io/modules/GoogleCloudPlatform/terraform-example-foundation-app/google
Apache License 2.0
33 stars 36 forks source link

Feat/3 networks #13

Closed chris-ingrisani closed 3 years ago

chris-ingrisani commented 3 years ago

This PR adds the network layer to the example app foundation.

chris-ingrisani commented 3 years ago

@bharathkkb I updated the code to remove the complete fork - let me know if this is sufficient. Will add readme by end of day.

bharathkkb commented 3 years ago

Thanks @chris-ingrisani, lets also make sure lint tests are passing and we switch temporary FW rules needed to gcloud commands in the readme.

chris-ingrisani commented 3 years ago

Thanks @chris-ingrisani, lets also make sure lint tests are passing and we switch temporary FW rules needed to gcloud commands in the readme.

@bharathkkb No problem! It looked like the lint tests were failing since the module isn't yet defined - even with source = "../../modules/base_shared_vpc" the lint tests weren't working. Should I be using the networking module instead? Undeclared input variables was the other issue and those were left out since they are included in the main base_shared_vpc module, but I can add them in to ensure the tests pass.

rutalreja-deloitte commented 3 years ago

@chris-ingrisani there is no modules folder in your commit, instead as we are not going to fork the CFT 3-networks you can use source = "github.com/terraform-google-modules/terraform-example-foundation/3-networks/modules/base_shared_vpc"

chris-ingrisani commented 3 years ago

@bharathkkb Please review latest commit and let me know if any additional changes are required.