GoogleCloudPlatform / terraform-example-foundation-app

https://registry.terraform.io/modules/GoogleCloudPlatform/terraform-example-foundation-app/google
Apache License 2.0
33 stars 36 forks source link

tfvars file should follow the same conventions used in the terraform-exemplo-foundation files #41

Closed daniel-cit closed 3 years ago

daniel-cit commented 3 years ago

Expected Behavior

Tfvar files should have example values following the same pattern used in the one in the foundation to smooth the transition from the example foundation repo to the app repo:

org_id                           = "000000000000"
billing_account                  = "000000-000000-000000"
terraform_service_account        = "org-terraform@prj-b-seed-2334.iam.gserviceaccount.com"
app_infra_pipeline_cloudbuild_sa = "<bu1_infra_pipeline_project_number>@cloudbuild.gserviceaccount.com"
enable_hub_and_spoke             = true

// Optional - for an organization with existing projects or for development/validation.
// Must be the same value used in previous steps.
//parent_folder = "01234567890"

Actual Behavior

org_id                           = "xxxxxx-xxxxxx-xxxxxx"
billing_account                  = "xxxxxxxxxxxx"
terraform_service_account        = "org-terraform@prj-seed-xxxx.iam.gserviceaccount.com"
app_infra_pipeline_cloudbuild_sa = "xxxxxxxxxxxx@cloudbuild.gserviceaccount.com"
app_cicd_project_id              = "prj-bu1-c-app-cicd-xxxx"
shared_vpc_host_project_id       = "prj-d-shared-base-xxxx"
shared_vpc_network_name          = "vpc-d-shared-base-spoke"
enable_hub_and_spoke             = true

# Optional
# parent_folder = ""

Steps to Reproduce the Problem

1. 1. 1.

Specifications