Closed dkassab closed 3 years ago
Hi @dkassab Thanks for the PR there are two lint errors:
A missing newline
Step #1 - "lint-tests": Checking for missing newline at end of file
Step #1 - "lint-tests": Error: No newline at end of file ./6-anthos-install/README.md
A missing required argument
Step #1 - "lint-tests": terraform_validate ./app-foundation/4-projects/shared
Step #1 - "lint-tests":
Step #1 - "lint-tests": Error: Missing required argument
Step #1 - "lint-tests":
Step #1 - "lint-tests": on infra_pipeline.tf line 44, in module "infra_pipelines":
Step #1 - "lint-tests": 44: module "infra_pipelines" {
Step #1 - "lint-tests":
Step #1 - "lint-tests": The argument "impersonate_service_account" is required, but no definition was
Step #1 - "lint-tests": found
The missing required argument was fixed in PR https://github.com/GoogleCloudPlatform/terraform-example-foundation-app/pull/40 It should be fixed if you rebase with the current version of main
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.
We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent.
in this pull request.
Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla
label to yes
(if enabled on your project).
ℹ️ Googlers: Go here for more info.
@googlebot I consent.
Fixes in c599738f5cdeaa8ff6f3c5f8a09acb3b16233e89
@dkassab and @daniel-cit Noticed missing instructions for
P.S Also a lot of files in the 6-anthos-install/acm-repos/root-config-repo/namespaces/boa/
repo folders are entirely commented out, maybe some instructions in the README are required to inform user what role the files play and at what stage
@dkassab and @daniel-cit Noticed missing instructions for
- acm root-sync yaml in ReadME, line should also have GKE_PROJECT_ID instead of PROJECT_ID
- cloud-sql-admin-secret yaml instruction to update this in ReadME
- app-secret-front yaml instruction to update this in ReadME as well as the correct project env variable GKE most likely
P.S Also a lot of files in the
6-anthos-install/acm-repos/root-config-repo/namespaces/boa/
repo folders are entirely commented out, maybe some instructions in the README are required to inform user what role the files play and at what stage
Fixes #51
bastion_members
in 5-infra/env/main.tf
and added supporting instruction in 6-READMELGTM @daniel-cit and @bharathkkb please review when you get a chance
the populate script is in the Bank of Anthos repo
cd ${HOME}
git clone https://github.com/GoogleCloudPlatform/bank-of-anthos.git
kubectl apply -n transactions --context ${CTX_1} -f ${HOME}/bank-of-anthos/extras/cloudsql/populate-jobs/populate-ledger-db.yaml
kubectl apply -n transactions --context ${CTX_2} -f ${HOME}/bank-of-anthos/extras/cloudsql/populate-jobs/populate-ledger-db.yaml
Updating documentation and fixing formatting issues.