GoogleCloudPlatform / terraform-example-foundation-app

https://registry.terraform.io/modules/GoogleCloudPlatform/terraform-example-foundation-app/google
Apache License 2.0
33 stars 36 forks source link

Instructions and code should have only one version of Anthos Service Mesh #65

Closed daniel-cit closed 3 years ago

daniel-cit commented 3 years ago

Expected Behavior

Instructions and code should have only on version of asm, asm-186-3, which will be the one installed and need to be the same used in the yamls used for namespace definition.

Actual Behavior

Instructions and code have two versions of asm different from the one that will be installed:

https://github.com/GoogleCloudPlatform/terraform-example-foundation-app/blob/de00f4fe2540912949a6fc32691c14964211c2d3/6-anthos-install/acm-repos/root-config-repo/namespaces/boa/transactions/transactions-ns.yaml#L22

https://github.com/GoogleCloudPlatform/terraform-example-foundation-app/blob/de00f4fe2540912949a6fc32691c14964211c2d3/6-anthos-install/acm-repos/root-config-repo/namespaces/boa/accounts/accounts-ns.yaml#L21

https://github.com/GoogleCloudPlatform/terraform-example-foundation-app/blob/de00f4fe2540912949a6fc32691c14964211c2d3/6-anthos-install/acm-repos/root-config-repo/namespaces/boa/frontend/frontend-ns.yaml#L22

https://github.com/GoogleCloudPlatform/terraform-example-foundation-app/blob/5b02673ce839e2ec0f35b2039f57d365e3fbcab9/6-anthos-install/README.md#L41-L42

https://github.com/GoogleCloudPlatform/terraform-example-foundation-app/blob/5b02673ce839e2ec0f35b2039f57d365e3fbcab9/6-anthos-install/README.md#L61

https://github.com/GoogleCloudPlatform/terraform-example-foundation-app/blob/5b02673ce839e2ec0f35b2039f57d365e3fbcab9/6-anthos-install/README.md#L105-L106

Steps to Reproduce the Problem

1. 1. 1.

Specifications