GoogleCloudPlatform / terraform-example-foundation-app

https://registry.terraform.io/modules/GoogleCloudPlatform/terraform-example-foundation-app/google
Apache License 2.0
33 stars 36 forks source link

istio proxy sidecars have repeated warning messages #67

Closed daniel-cit closed 1 year ago

daniel-cit commented 3 years ago

Expected Behavior

No errors in the Istio-proxy side car

Actual Behavior

We see the same errors reported in this issue https://github.com/kubeflow/gcp-blueprints/issues/70

Steps to Reproduce the Problem

  1. follow the instruction up to step 6

Specifications

daniel-cit commented 3 years ago

The errors are gone after using the fix in the kubeflow issue:

curl --request POST \
--header "Authorization: Bearer `gcloud auth print-access-token`" \
--data '' \
--fail \
"https://meshconfig.googleapis.com/v1alpha1/projects/$(GKE_PROJECT_ID):initialize"
daniel-cit commented 3 years ago

Hi @dkassab do you know if this is an issues that may affect the deploy?

@bharathkkb pointed out that in the source code for the installation scrip for ASM: https://github.com/GoogleCloudPlatform/anthos-service-mesh-packages/blob/c9f08f5469b20f0c92f281b32c2cb001bad550bc/scripts/asm-installer/install_asm#L2071

init_meshconfig() {
  info "Initializing meshconfig API..."
  if [[ "${USE_HUB_WIP}" -eq 1 ]]; then

The curl command is only executed by the installation script, install_asm, if we provide the Hub Workload Identity Pool option, -o hub-meshca, in the initial installation.

Should we add instructions to manually run the curl command ?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days