search

GoogleCloudPlatform / terraform-google-cloud-functions

Deploys Cloud Functions (Gen 2)
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-functions/google
Apache License 2.0
30 stars 25 forks source link

chore: skips teardown for secure-cloud-func-internal-server #110

Closed g-awmalik closed 1 week ago

daniel-cit commented 3 months ago

@apeabody Could you please update this PR?

daniel-cit commented 3 months ago

@g-awmalik looking at the changes, this Pull Request is skipping the whole secure-cloud-func-internal-server tests , not only the teardown (destroy) phase .

Is this the original intent ?

daniel-cit commented 3 months ago

@g-awmalik to skip the teardown phaser of the secure examples wouldn't be enough to comment out this ones:

prabhu34 commented 3 months ago

@g-awmalik looking at the changes, this Pull Request is skipping the whole secure-cloud-func-internal-server tests , not only the teardown (destroy) phase .

Is this the original intent ?

No, definitely not the intent. The teardown was commented out and left stale resources in the project. Was unable to proceed further and I had to comment the entire secure-cloud-func-internal-server to debug the issue.

apeabody commented 2 months ago

@g-awmalik - The added retry during the teardown appears to have worked around the issue: https://github.com/GoogleCloudPlatform/terraform-google-cloud-functions/pull/112

github-actions[bot] commented 3 weeks ago

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days