search

GoogleCloudPlatform / terraform-google-cloud-functions

Deploys Cloud Functions (Gen 2)
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-functions/google
Apache License 2.0
30 stars 25 forks source link

feat: add build service account argument #130

Closed caetano-colin closed 1 week ago

caetano-colin commented 1 week ago

There are environments in which neither the Cloud Build Service Account nor the Compute Engine Service Account can be used, in these cases the user would need to specify a custom service account for running the builds. Currently the module does not support this argument. This PR adds the fields necessary to externalize the build service account argument.

References: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/cloudfunctions2_function#nested_build_config https://github.com/GoogleCloudPlatform/terraform-google-cloud-functions/issues/129 https://github.com/terraform-google-modules/terraform-example-foundation/issues/1269

eeaton commented 1 week ago

@apeabody Can you please trigger CI tests for this? It helps address 1269 in the foundation repo

apeabody commented 1 week ago

/gcbrun

caetano-colin commented 1 week ago

Just fixed the variable description, might need the integration build to be triggered again @apeabody

apeabody commented 1 week ago

/gcbrun

daniel-cit commented 1 week ago

@gtsorbo @prabhu34 Could you PTAL?