search

GoogleCloudPlatform / terraform-google-cloud-functions

Deploys Cloud Functions (Gen 2)
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-functions/google
Apache License 2.0
31 stars 27 forks source link

feat: adds secure cloud-function-core sub-module #20

Closed amandakarina closed 1 year ago

amandakarina commented 1 year ago

Hey folks

This PR adds the initial version of sub-module for secure-cloud-functions, following the security best practices.

Could you, please, take a look on it?

Thanks!

amandakarina commented 1 year ago

/gcbrun

amandakarina commented 1 year ago

/gcbrun

amandakarina commented 1 year ago

Thanks @amandakarina! - Would it be possible to add an example/test that uses this module, as currently it won't be covered by the INT tests.

Hey @apeabody

Can we follow the standard used in secure-cloud-run?

An standalone example and the secure-cloud-function example? Those examples use the composition module (to be done) to be tested.

apeabody commented 1 year ago

Thanks @amandakarina! - Would it be possible to add an example/test that uses this module, as currently it won't be covered by the INT tests.

Hey @apeabody

Can we follow the standard used in secure-cloud-run?

An standalone example and the secure-cloud-function example? Those examples use the composition module (to be done) to be tested.

Sure, sounds good to me!