search

GoogleCloudPlatform / terraform-google-cloud-functions

Deploys Cloud Functions (Gen 2)
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-functions/google
Apache License 2.0
31 stars 27 forks source link

feat: Adds example of secure-cloud-function triggered by BigQuery #26

Closed amandakarina closed 1 year ago

amandakarina commented 1 year ago

Hey folks,

This PR adds an usage of secure-cloud-function being triggered by BigQuery.

The linting errors requires a new version of Cloud run module, after https://github.com/GoogleCloudPlatform/terraform-google-cloud-run/pull/119 is merged. I will need to change the source to the new version instead of the branch in my fork.

amandakarina commented 1 year ago

/gcbrun

prabhu34 commented 1 year ago

@amandakarina Lint errors here. Can you run the link checks locally using make?

amandakarina commented 1 year ago

@amandakarina Lint errors here. Can you run the link checks locally using make?

Hey @prabhu34

These errors requires a new version of Cloud run module, after https://github.com/GoogleCloudPlatform/terraform-google-cloud-run/pull/119 is merged.

I will need to change the source to the new version instead of the branch in my fork.