search

GoogleCloudPlatform / terraform-google-cloud-functions

Deploys Cloud Functions (Gen 2)
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-functions/google
Apache License 2.0
33 stars 27 forks source link

feat: Add available_cpu to service_config #65

Closed andrewwljackson closed 1 year ago

andrewwljackson commented 1 year ago

In reference to this issue brought up: https://github.com/GoogleCloudPlatform/terraform-google-cloud-functions/issues/63

gtsorbo commented 1 year ago

/gcbrun

gtsorbo commented 1 year ago

/gcbrun

gtsorbo commented 1 year ago

/gcbrun

andrewwljackson commented 1 year ago

@gtsorbo sorry about missing the docs, is this ok for merge?

jeunii commented 11 months ago

Hello. Im adding the available_cpu parameter like this

module "cloud_functions_pattern1a_copy_paste" {
  source  = "GoogleCloudPlatform/cloud-functions/google"
  version = "0.4.1"
...

  service_config = {
    available_memory = "2Gi"
    available_cpu    = 2
    min_instance_count = "0"
    timeout_seconds = "60"
  }

But the generated CF only has 1 CPU. Ive also tried it as 

    available_cpu    = "2"
    # and
     available_cpu    = "2000m"

But it doesnt seem to be taking it.

Im using tf version 1.5.7

jeunii commented 11 months ago

I see this change in not in the latest release of the module ? When can we expect that ?