GoogleCloudPlatform / terraform-google-cloud-run

Deploys apps to Cloud Run, along with option to map custom domain
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-run/google
Apache License 2.0
137 stars 89 forks source link

feat!: adds support to multiple service projects and Shared VPC #115

Closed amandakarina closed 1 year ago

amandakarina commented 1 year ago

Hey folks,

this PR adds support to multiple services project and the creation of a Shared VPC in a network project in the harness sub-module.

Could you, please, take a look on it?

bharathkkb commented 1 year ago

I have not tested this before but I believe what will happen is TF registry will stop tracking old version after current release and these will be added as new submodules. I generally don't recommend this unless there is a strong rationale.

Like Grant mentioned, we should rename the versions.tf to reflect new name though.

amandakarina commented 1 year ago

Add validation to harness as well, then LGTM

Please write some upgrade notes regarding the submodule name change to inform users of navigating the breaking change

hey @gtsorbo where should I put these notes? in the modules readmes?

gtsorbo commented 1 year ago

Add validation to harness as well, then LGTM Please write some upgrade notes regarding the submodule name change to inform users of navigating the breaking change

hey @gtsorbo where should I put these notes? in the modules readmes? @amandakarina Can you make a short upgrade guide similar to this: https://github.com/terraform-google-modules/terraform-google-lb-http/blob/master/docs/upgrading_to_v8.0.md

amandakarina commented 1 year ago

/gcbrun