feat(job-exec): Add support for multiple arguments

GoogleCloudPlatform / terraform-google-cloud-run

Deploys apps to Cloud Run, along with option to map custom domain

https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-run/google

Apache License 2.0

141 stars 96 forks source link

feat(job-exec): Add support for multiple arguments #118

Closed BapRx closed 1 year ago

BapRx commented 1 year ago

Hello,

This PR brings a few fixes and improvements for the job-exec submodule. I'm open for any suggestion if changes are needed.

fix: Update env_secret_vars structure chore: Configure launch_stage as variable feat: Add support for volumes, volume_mounts, vpc_access, labels and max_retries

prabhu34 commented 1 year ago

/gcbrun

BapRx commented 1 year ago

Hey @prabhu34, can you please tell me what's wrong with the terraform-google-cloud-run-int-trigger (cloud-foundation-cicd) check? I don't have access to the build logs.

prabhu34 commented 1 year ago

/gcbrun

prabhu34 commented 1 year ago

/gcbrun

BapRx commented 1 year ago

Hey @prabhu34 we would really like this to be merged if it's possible :pray: Thank you

BapRx commented 1 year ago

Hello @prabhu34 @gtsorbo, could you please have a look at this MR? The tests are OK and it was already reviewed :pray:

prabhu34 commented 1 year ago

/gcbrun

gtsorbo commented 1 year ago

/gcbrun