GoogleCloudPlatform / terraform-google-cloud-run

Deploys apps to Cloud Run, along with option to map custom domain
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-run/google
Apache License 2.0
136 stars 87 forks source link

feat(probes): Add support for startup and liveness probes #120

Closed cyberbliss closed 1 year ago

cyberbliss commented 1 year ago

Hi

This PR is to enable startup and liveness probes to be specified. Open to suggestions if folks feel there is more I should include in this PR.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

prabhu34 commented 1 year ago

/gcbrun

prabhu34 commented 1 year ago

Possible duplicates #101 and #120

cyberbliss commented 1 year ago

Possible duplicates #101 and #120

Ah, my bad. I hadn't seen #101. Both PRs are very similar so it would be good to get one of them approved and merged. What is required to make that happen?

vitor-zanoni commented 1 year ago

Hello @prabhu34 @gtsorbo @apeabody Can someone have a look here? This is a valuable and much expected feature 👯 😃 Thanks in advance for your efforts on it.

prabhu34 commented 1 year ago

/gcbrun

prabhu34 commented 1 year ago

Hello @prabhu34 @gtsorbo @apeabody Can someone have a look here? This is a valuable and much expected feature 👯 😃 Thanks in advance for your efforts on it.

Collaborators need to trigger the builds.

gtsorbo commented 1 year ago

/gcbrun

andrewmackett commented 1 year ago

This would be a great feature to have. Is there anything I can do to help get this PR reviewed and merged? It appears as though it just needs to be brought up to date with the main branch.

andrewmackett commented 1 year ago

Please may this be updated with the main branch so that it could be reviewed and merged? @cyberbliss @prabhu34 @gtsorbo

cyberbliss commented 1 year ago

Sadly I think it would be a waste of my time. The maintainers seem.... unenthusiastic about dealing with PRs from external parties

andrewmackett commented 1 year ago

Sadly I think it would be a waste of my time. The maintainers seem.... unenthusiastic about dealing with PRs from external parties

That's disappointing to hear. I was hoping to use this module more after creating a load of Cloud Run services with another Cloud Run module that's now not adding new features.

With this repo having such a detailed document on contributing I hoped getting new features added wouldn't be problematic.

@prabhu34 @anamer @gtsorbo are you able to confirm if you're accepting contributions or not?

gtsorbo commented 1 year ago

/gcbrun

gtsorbo commented 1 year ago

Duplicate to #101

andrewmackett commented 1 year ago

I appreciate maintaining a public repo isn't easy, so just wanted to say thank you @gtsorbo.