search

GoogleCloudPlatform / terraform-google-cloud-run

Deploys apps to Cloud Run, along with option to map custom domain
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-run/google
Apache License 2.0
136 stars 87 forks source link

fix : Correct the logic to accept the secrets as env variable. #136

Closed gouravbansal11 closed 1 year ago

gouravbansal11 commented 1 year ago

When we are creating cloud run with reference of secrets this module failed with below error. │ Error: Unsupported block type │ │ on .terraform\modules\job\modules\job-exec\main.tf line 41, in resource "google_cloud_run_v2_job" "job": │ 41: dynamic "value_from" { │ │ Blocks of type "value_from" are not expected here. ╵ Detailed Issue Fixed the code to support the secret reference.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gtsorbo commented 1 year ago

@gouravbansal11 Thanks for the contribution! The logic for secrets inclusion (value_from > value_source) was fixed in another recent PR: https://github.com/GoogleCloudPlatform/terraform-google-cloud-run/pull/118 so closing this as duplicate.