GoogleCloudPlatform / terraform-google-cloud-run

Deploys apps to Cloud Run, along with option to map custom domain
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-run/google
Apache License 2.0
136 stars 87 forks source link

Support for 2nd generation Execution Environment #151

Closed fabrana closed 7 months ago

fabrana commented 11 months ago

It would be helpful to allow setting the Cloud Run Execution Environment.

Terraform GCP provider supports the functionality: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/cloud_run_v2_service#execution_environment

so exposing it in the module should be possible

github-actions[bot] commented 9 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

fabrana commented 9 months ago

Still interested in this

github-actions[bot] commented 7 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

Azuka commented 7 months ago

Bump

prabhu34 commented 7 months ago

google_cloud_run_service the module was using this resource during the module development. google_cloud_run_v2_service is the latest resource for Cloud Run Gen 2.

The existing resource as part of this module still supports the execution environment [1] using the annotations.

[1] run.googleapis.com/execution-environment sets the execution environment where the application will run.

fabrana commented 7 months ago

Thanks for the suggestion @prabhu34

For the record, adding this to module "cloud_run" { ... works

template_annotations = {
  ...
  "run.googleapis.com/execution-environment" = "gen2",
  ...
}