search

GoogleCloudPlatform / terraform-google-cloud-run

Deploys apps to Cloud Run, along with option to map custom domain
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-run/google
Apache License 2.0
131 stars 81 forks source link

Add client.knative.dev/nonce to lifecycle ignore_changes #169

Closed lalpert closed 4 months ago

lalpert commented 7 months ago

When I run terraform apply after deploying my cloudrun code via gcloud run deploy, even if there are no changes to my terraform config, it shows a diff to client.knative.dev/nonce. Example below: 

 ~ template {
          ~ metadata {
              ~ labels      = {
                  - "client.knative.dev/nonce"            = "xyz" -> null
                    # (1 unchanged element hidden)
                }
                # (2 unchanged attributes hidden)
            }

            # (1 unchanged block hidden)
        }

Would it make sense to add this label to the lifeycle ignore_changes? (https://github.com/GoogleCloudPlatform/terraform-google-cloud-run/blob/main/main.tf#L191-L202)

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

stbarillas commented 5 months ago

Created PR https://github.com/GoogleCloudPlatform/terraform-google-cloud-run/pull/185 for this issue