GoogleCloudPlatform / terraform-google-cloud-run

Deploys apps to Cloud Run, along with option to map custom domain
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-run/google
Apache License 2.0
131 stars 81 forks source link

Cloud Run Job missing argument: encryption_key #172

Closed maksymsereda closed 3 months ago

maksymsereda commented 6 months ago

Hi, it looks like the encryption_key argument is missing in Cloud Run Job terraform module. Is it possible to add as it was done in Cloud Run Service?

prabhu34 commented 6 months ago

google_cloud_run_service the module was using this resource during the module development. google_cloud_run_v2_service is the latest resource for Cloud Run Gen 2, where the encryption_key is supported.

The existing resource as part of this module still supports the encryption key [1] using the annotations.

[1] run.googleapis.com/encryption-key sets the CMEK key reference to encrypt the container with.

maksymsereda commented 6 months ago

Hi @prabhu34, thank you for your response. But I think that we are talking about different things. I asked about Jobs, not Services

prabhu34 commented 5 months ago

@maksymsereda Apologies. I confused the comment with other issue and misguided by Is it possible to add as it was done in Cloud Run Service?.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days