GoogleCloudPlatform / terraform-google-cloud-run

Deploys apps to Cloud Run, along with option to map custom domain
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-run/google
Apache License 2.0
139 stars 91 forks source link

fix: ignoring client.knative.dev/nonce changes #185

Closed stbarillas closed 6 months ago

stbarillas commented 7 months ago

adding 'client.knative.dev/nonce' to be ignored by lifecycle policy to prevent unnecessary terraform drift.

This addresses this open issue

Fixes: #169

google-cla[bot] commented 7 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

stbarillas commented 7 months ago

@prabhu34 @anamer @gtsorbo , I suspect terraform-google-cloud-run-int-trigger is failing because I do not have permissions to that GCP project and lint needs approval. Please advise

bharathkkb commented 7 months ago

/gcbrun

bharathkkb commented 7 months ago

/gcbrun

stbarillas commented 7 months ago

@bharathkkb , I can't view why terraform-google-cloud-run-int-trigger is failing (GCP permissions)

Not sure if this small change would cause the error. Any insight you could share with me?

apeabody commented 7 months ago

@bharathkkb , I can't view why terraform-google-cloud-run-int-trigger is failing (GCP permissions)

Not sure if this small change would cause the error. Any insight you could share with me?

Looks like it might be a flake, re-triggered

stbarillas commented 7 months ago

@bharathkkb , I can't view why terraform-google-cloud-run-int-trigger is failing (GCP permissions) Not sure if this small change would cause the error. Any insight you could share with me?

Looks like it might be a flake, re-triggered

Not sure if still flakey or other issue

stbarillas commented 7 months ago

Could I get another /gcbrun from a collaborator? :) TY!

prabhu34 commented 7 months ago

/gcbrun

stbarillas commented 7 months ago

I made the inadvertent mistake of turning off auto-merge. Can a collaborator hit merge for me please :)

Appreciate all the help guys!

stbarillas commented 7 months ago

ping for a merge

stbarillas commented 6 months ago

Ping for a merge

stbarillas commented 6 months ago

Need a /gcbrun from a collaborator and a manual merge afterward

apeabody commented 6 months ago

/gcbrun

stbarillas commented 6 months ago

Thank you apeabody!