search

GoogleCloudPlatform / terraform-google-cloud-run

Deploys apps to Cloud Run, along with option to map custom domain
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-run/google
Apache License 2.0
131 stars 81 forks source link

Cloud Run v2 support #198

Closed bharathkkb closed 2 weeks ago

prabhu34 commented 2 months ago

This is going to be a completely new API or TF resource google_cloud_run_v2_service.

Two options I see, which will be a destructive change in both cases and rebuild the submodules and solutions developed here.

  1. Conditional counts and add 2 resource blocks.
  2. Use only the latest resource block (which seems to offer similar inputs at the first glance).

Option 3 would be a submodule which will be independent and non destructive.

bharathkkb commented 2 months ago

I am thinking we could start with 3 and then in a future breaking change move it as the main module while making v1 into a submodule.

bharathkkb commented 2 months ago

@q2w will take a pass at the submodule

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days