GoogleCloudPlatform / terraform-google-cloud-run

Deploys apps to Cloud Run, along with option to map custom domain
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-run/google
Apache License 2.0
139 stars 91 forks source link

fix: Various fixes to volumes and volume mounts #213

Closed vale-qb closed 5 days ago

vale-qb commented 3 months ago

Fixing 3 issues with volumes and volume mounts:

  1. making secret optional, in case one wants to use just database, cloud storage or nfs
  2. changing cloud_sql_instance.instances type to list of strings, to match the signature of the underlying google_cloud_run_v2_service
  3. fixing the values access in volumes, for gcs and nfs
vale-qb commented 3 months ago

Hi. Any update on this, please?

apeabody commented 2 months ago

/gcbrun

apeabody commented 2 months ago

/gcbrun

vale-qb commented 6 days ago

Hi. Any updates, please?

apeabody commented 5 days ago

/gcbrun