GoogleCloudPlatform / terraform-google-cloud-run

Deploys apps to Cloud Run, along with option to map custom domain
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-run/google
Apache License 2.0
141 stars 96 forks source link

Support optionally creating and managing runtime SA in v2 module #217

Closed bharathkkb closed 2 months ago

bharathkkb commented 3 months ago

It would be nice to optionally create a user managed SA in cloud run v2 module so user does not have to manage it out of band. I propose we can keep it true by default (breaking change) since it is a best practice over using default SA. Example from GKE https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/a37bf7ed87d7f17e897926ac2ddf59e9b13030f5/sa.tf#L41