search

GoogleCloudPlatform / terraform-google-cloud-run

Deploys apps to Cloud Run, along with option to map custom domain
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-run/google
Apache License 2.0
143 stars 95 forks source link

secure-cloud-run should expose the timeout_seconds input to secure-cloud-run-core #224

Open massfords opened 3 months ago

massfords commented 3 months ago

I am using the secure-cloud-run module but find that I need to modify the timeout for the cloud run service it creates.

There is an input variable defined for this in secure-cloud-run-core with a 2 minute default, but I don't see this variable included in the inputs for the wrapper module secure-cloud-run.

Unless I'm mistaken, I can't do this without the wrapper module including timeout_seconds in its variables.tf and also passing it into its invocation of the secure-cloud-run-core module.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

massfords commented 1 month ago

There is an open PR for this issue at #225 but it looks like there are issues with the build since nearly all the PR's in this project have failing builds.

I've worked around the need for secure-cloud-run exposing this variable by copying the entirety of the cloud run terraform scripts into my project but it would be nice to avoid adding all of this code just to set a single property.