Closed danielezer closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
I signed it!
On 11 Dec 2018, at 14:33, googlebot notifications@github.com wrote:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/. Corporate signers
Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot http://go/cla#troubleshoot (Public version https://opensource.google.com/docs/cla/#troubleshoot). The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/. The email used to register you as an authorized contributor must also be attached to your GitHub account https://github.com/settings/emails. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/terraform-google-managed-instance-group/pull/35#issuecomment-446186693, or mute the thread https://github.com/notifications/unsubscribe-auth/AfYfuab9iyEi2UsoSeZekGeYEaNcX0QQks5u36YRgaJpZM4ZNUF2.
CLAs look good, thanks!
This should resolve issue #36
@danisla Can you please review this? I am currently using my fork as the module but I would really like to merge my change so that I can use the official module
LGTM, thanks!
Currently, the module_enabled flag is ignored for the mig-health-check resources and only the http_health_check flag is used. This merge request will change that behaviour and make the module use both variables.