GoogleCloudPlatform / terraform-google-managed-instance-group

Modular Google Compute Engine managed instance group for Terraform.
Apache License 2.0
63 stars 139 forks source link

Issue#38 - Module not working in the latest versions of the terraform google providers #39

Closed dcaba closed 5 years ago

dcaba commented 5 years ago

Trying to incorporate the minimum set of updates to make this compatible with the second version of the provider (btw, it requires the new beta one, as some options this module was already using have been moved there). I have not updated other items (like the examples), but at least, it seems to work

https://github.com/GoogleCloudPlatform/terraform-google-managed-instance-group/issues/38

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

dcaba commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

RafiGreenberg commented 5 years ago

What's the status of this?

dcaba commented 5 years ago

good question... i didnt get feedback so far. If the master branch is now working for you, feel free to clone this one, or make terraform to point to this

dcaba commented 5 years ago

Given lack of feedback from project maintainers, I close. However, commits were also included to this PR that was triggered in parallel: https://github.com/GoogleCloudPlatform/terraform-google-managed-instance-group/pull/41