Feature/repair module and autoscaling example

GoogleCloudPlatform / terraform-google-managed-instance-group

Modular Google Compute Engine managed instance group for Terraform.

Apache License 2.0

63 stars 139 forks source link

Feature/repair module and autoscaling example #41

Closed joshuamkite closed 4 years ago

joshuamkite commented 5 years ago

I have built on @dcaba fork to make this module and the 'autoscaling' example work with current provider versions

In 'autoscaling' example:

Fixes for current version providers
Add service public IP ouput
Improve runbook
Add Terraform inputs and outputs to README

In Module:

Fix provider for google_beta provider
Fix google_compute_region_instance_group_manager.default config
Add Terraform inputs and outputs to README
Add quotes variable names - advised best practice and much easier in IDE

googlebot commented 5 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

dcaba commented 5 years ago

I confirm its not a problem to incorporate my commit here. Thanks for the extra improvements/amends

joshuamkite commented 5 years ago

Thanks @dcaba but you will need to do the CLA form for this PR to progress

dcaba commented 5 years ago

It was already signed, unless Im missing something...

joshuamkite commented 5 years ago

Strange. I still failing check 'cla/google — CLAs are signed, but unable to verify author consent' as before.

dcaba commented 5 years ago

I think I know where the problem is... the commits are associated to my corporate email (dcaballero at Fastly), and we have a corporate agreement. So I need to be included there, but I dont know who is the point of contact... the bot says this, that may help to sort it out:

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).

Can you go to that link and maybe you can help me to amend that? If not, squash my commit and push -f...

joshuamkite commented 5 years ago

Thanks for your review compliments and previous work

benmoss commented 4 years ago

FYI, the CLA bot will not update the state of the check when it gets into this state. It said that in its last message, it's a "terminal state."

This PR works for me. It'd be great if we got this merged, or made it clear this library was abandoned.

benmoss commented 4 years ago

FYI a note was added to the README stating that this module isn't maintained anymore: https://github.com/GoogleCloudPlatform/terraform-google-managed-instance-group/commit/b1557722d6ea188d2378ac4ef9d109eac46b47f0

morgante commented 4 years ago

Correct, please switch to https://github.com/terraform-google-modules/terraform-google-vm/tree/master/modules/mig instead.