search

GoogleCloudPlatform / terraform-google-nat-gateway

Modular NAT Gateway on Google Compute Engine for Terraform.
Apache License 2.0
156 stars 133 forks source link

Is the Managed Instance Group in the examples needed? #89

Open idsvandermolen opened 6 years ago

idsvandermolen commented 6 years ago

A lot of the examples (ha-nat-gateway and multiple-nat-environments for example) use the nat-gateway-module and in addition to this use add their own managed-instance-group. For example at https://github.com/GoogleCloudPlatform/terraform-google-nat-gateway/blob/master/examples/ha-nat-gateway/main.tf#L81 .

However, the nat-gateway-module already uses a managed instance group to manage the nat gateway instances (see https://github.com/GoogleCloudPlatform/terraform-google-nat-gateway/blob/master/main.tf#L47).

Unless I'm mistaken I think the managed instances groups in the examples are not used at all and could be removed.

idsvandermolen commented 6 years ago

It looks like these MIGs are used to manage the example instances and so are not directly used in the NAT gateway setup.