search

GoogleCloudPlatform / terraform-google-netapp-volumes

Deploy NetApp Storage Volumes
https://registry.terraform.io/modules/GoogleCloudPlatform/netapp-volumes/google
Apache License 2.0
2 stars 3 forks source link

Monthly Sanpshot option for Netapp Volumes #23

Closed koushikgongireddy closed 4 months ago

koushikgongireddy commented 5 months ago

Hi,

Currently this module only supports daily, hourly and weekly Snapshot option and doesn't support Monthly snapshot. https://github.com/GoogleCloudPlatform/terraform-google-netapp-volumes/blob/main/main.tf#L57

But its provided and supported by Terraform Registry -https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/netapp_volume#monthly_schedule

Can we please add support for Monthly snapshot option.

Thanks Koushik

okrause commented 5 months ago

@imrannayer FYI. Provider supports monthly, but the TF module not (yet). Can you please have a look?

koushikgongireddy commented 5 months ago

@okrause @imrannayer Created PR for the same - https://github.com/GoogleCloudPlatform/terraform-google-netapp-volumes/pull/25 Please check once

okrause commented 5 months ago

@okrause @imrannayer Created PR for the same - #25 Please check once

LGTM, thank you!

imrannayer commented 4 months ago

Fixed in #27