GoogleCloudPlatform / terraform-mean-cloudrun-mongodb

Apache License 2.0
15 stars 5 forks source link

add CI/CD #18

Closed bleything closed 1 year ago

bleything commented 2 years ago

Updates the Terraform code to deploy a CI/CD pipeline for the demo application. See discussion in #15.

/closes #15

bleything commented 2 years ago

Alright, here's a simple pipeline. I still need to do some cleanup and update the README but here's how you can get started:

Let me know if you run into any issues at all, no matter how small. There's some finicky stuff in here and I'd like to sort it out if possible.

I'll update when everything's working right and I have docs.

bleything commented 1 year ago

FYI - I reworked my original commits to use a module instead of creating resources in the root module. This makes it easier to put behind a feature flag, because you can just turn the module on or off instead of having to make every resource conditional.

Anyway, that's what the force push was about.

bleything commented 1 year ago

... turns out the module idea, while conceptually sound, creates more problems than it solves right now. we can revisit that change later, but for now I'm reverting it.

bleything commented 1 year ago

@villasenor for some reason I can't mark you as a reviewer but please take a look if you've got a few minutes.

mikegcoleman commented 1 year ago

LGTM