search

GoogleCloudPlatform / terraform-provider-cdap

Custom Terraform Provider for CDAP
https://registry.terraform.io/providers/GoogleCloudPlatform/cdap/
Apache License 2.0
12 stars 12 forks source link

Support System Profiles #84

Open j-don opened 4 years ago

j-don commented 4 years ago

Right now, the cdap_profile resource requires a namespace, and omitting it uses the "default" namespace, so it is currently impossible to configure System Compute Profiles.

umairidris commented 4 years ago

It's been a while since I looked into this but one of the caveats is data fusion by default sets some system profile properties, so if we send an API with new ones it will overwrite the existing ones. Trying to fetch and append existing ones is unidiomatic for Terraform. You also can't create/delete system namespace so it doesn't fit super well to the Terraform model. Thus, we chose to just support profiles at the namespace level.

I would encourage using namespace level profiles as a best practice.

If this is a highly desired feature I would consider accepting a PR that added a 'type' field that defaults to 'NAMESPACE', but can also be set to 'SYSTEM'. In the case it is NAMESPACE then we check the namespace field, else it is ignored.

It would need to fit the Terraform model however, so would need answers to the existing properties and creation/deletion questions above.