GoogleCloudPlatform / terraform-python-testing-helper

Simple Python test helper for Terraform.
https://pypi.org/project/tftest/
Apache License 2.0
214 stars 31 forks source link

[feature] added support to pass a complex dict #69

Closed MrImpossibru closed 1 year ago

MrImpossibru commented 1 year ago

https://github.com/GoogleCloudPlatform/terraform-python-testing-helper/issues/68

added support to pass a complex dict to the tf_vars parameter

Like that: tf_vars = { "pep_spec": { "pep1": "test", "list": [ "item1", "item2" ] }, "list2": [ "item1", "item2" ] }

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ludoo commented 1 year ago

Can you add a test? If you're too busy let me know and I can add it, provided I can work on the fork.

MrImpossibru commented 1 year ago

@ludoo I can try, I'm not a python dev TBH :)

MrImpossibru commented 1 year ago

@ludoo I commited some tests

MrImpossibru commented 1 year ago

@ludoo Should I do something with the Linting?

ludoo commented 1 year ago

@ludoo Should I do something with the Linting?

if you have time, linting we use is autopep8 with 2 spaces for tab stop, I can do it quickly as soon as I have 5 free minutes, let me try

ludoo commented 1 year ago

Merging this, thanks a lot for your patience. I am going to release it on pypi ASAP

MrImpossibru commented 1 year ago

Thanks a lot!