GoogleCloudPlatform / terraform-validator

Terraform Validator is not an officially supported Google product; it is a library for conversion of Terraform plan data to CAI Assets. If you have been using terraform-validator directly in the past, we recommend migrating to `gcloud beta terraform vet`.
https://cloud.google.com/docs/terraform/policy-validation
Apache License 2.0
437 stars 93 forks source link

Don't reuse liveapp service name in examples #1464

Closed modular-magician closed 1 year ago

modular-magician commented 1 year ago

Fixes https://github.com/hashicorp/terraform-provider-google/issues/9996

Fixes TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample, may fix TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample

Seems like we reused an appengine service name. I think they're impossible to delete, so we don't add a random suffix. Also remove the unused service_id vars entry.

If this PR is for Terraform, I acknowledge that I have:

Release Note Template for Downstream PRs (will be copied)

Derived from https://github.com/GoogleCloudPlatform/magic-modules/pull/7482